improve error type definitions for more clarity #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhan-okbay-cko
force-pushed
the
update/define-error-types
branch
from
c97046d to
280e7e9
Compare
aashna-narula-cko
approved these changes
Mar 19, 2024
Contributor
Author
|
This will be a breaking change so parking it aside for now. |
ehab-al-cko
previously approved these changes
Mar 19, 2024
okhan-okbay-cko
force-pushed
the
update/define-error-types
branch
from
799a626 to
6afd1e0
Compare
okhan-okbay-cko
force-pushed
the
update/define-error-types
branch
from
6afd1e0 to
38b620a
Compare
ehab-al-cko
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually were not throwing any other errors than the decoding errors + CheckoutNetworkError. So, I added a new error case to wrap that in.